[Padre-dev] Fwd: Re: [Padre] #148: Use consistent coding style in padre sources

[Jerome Quelin]

On 09/03/25 13:20 +1100, Adam Kennedy wrote:
> use Class::XSAccessor getters => { editor           => 'editor',
>                                    filename         => 'filename',
>   # TODO is this read_only or what?
>                                    get_mimetype     => 'mimetype',
>                                    get_newline_type => 'newline_type',
>                                    errstr           => 'errstr',
>     },
>     setters => { _set_filename    => 'filename',       # TODO temporary hack
>                  set_newline_type => 'newline_type',
>                  set_mimetype     => 'mimetype',
>                  set_errstr       => 'errstr',
>                  set_editor       => 'editor',
>     };
> 
> This kind of thing looks bizarre.

it is now:

use Class::XSAccessor getters => {
    editor           => 'editor',
    filename         => 'filename',       # TODO is this read_only or what?
    get_mimetype     => 'mimetype',
    get_newline_type => 'newline_type',
    errstr           => 'errstr',
    },
    setters => {
    _set_filename    => 'filename',       # TODO temporary hack
    set_newline_type => 'newline_type',
    set_mimetype     => 'mimetype',
    set_errstr       => 'errstr',
    set_editor       => 'editor',
    };

i don't know why the inner list is not indented. any perltidy guru
around?


> On the subject of tabs, perltidy has destroyed most (but not all) of
> all the tabs and replaced them with spaces. You might have to rollback
> to a tabbed one and rerun it in order to fix that.

uh, i don't find any tabs in the files... all tabs have been removed and
perltidy is using 4 spaces.


> I think we were using cuddled } else { before, but these have been
> turned into }\nelse {

fixed.


> It also is destroying low-width indented pairs, which turns
> 
> $style = {
>     use_tabs => 1,
>     tabwidth  => 1,
>     indentwidth => 1,
> };
> 
> into
> 
> $style = { use_tabs => 1, tabwidth => 8, indentwidth => 8, };

fixed.

any other comments?
jérôme 
-- 
jquelin at gmail.com