[Padre-dev] [Padre-commit] rev 3188 - trunk/Padre/privinc/Module/Install/PRIVATE

[Gabor Szabo]

That's unfortunately not good.

The recommendation is that if Makefile.PL detects a missing prereq
it should exit with 0 and NOT create Makefile.
This is used then by the testers to differentiate between a failure in
the current
package (when Makefile.PL would exit with a non-zero exit code) and
failures in the prereqs that should be reportedt then as NA or UNKNOWN.
(I don't remember which one).

See http://wiki.cpantesters.org/wiki/CPANAuthorNotes
for an explanation.

I know it is not ideal but I think it is better to play along with them.

Gabor


On Sat, Mar 7, 2009 at 12:23 AM,  <svn at perlide.org> wrote:
> Author: dam
> See also: http://padre.perlide.org/changeset/3188
> Date: 2009-03-06 14:23:52 -0800 (Fri, 06 Mar 2009)
> New Revision: 3188
>
> Modified:
>   trunk/Padre/privinc/Module/Install/PRIVATE/Padre.pm
> Log:
> privinc/.../Padre.pm: make nono() exit with non-zero code
>
> this helps calling code detect if something goes wrong
>
> Modified: trunk/Padre/privinc/Module/Install/PRIVATE/Padre.pm
> ===================================================================
> --- trunk/Padre/privinc/Module/Install/PRIVATE/Padre.pm 2009-03-06 16:33:29 UTC (rev 3187)
> +++ trunk/Padre/privinc/Module/Install/PRIVATE/Padre.pm 2009-03-06 22:23:52 UTC (rev 3188)
> @@ -89,7 +89,7 @@
>  sub nono {
>        my $msg = shift;
>        print STDERR "$msg\n";
> -       exit(0);
> +       exit(1);
>  }
>
>  sub make_exe {
>