[Padre-dev] about find & search dialogs

[Steffen Mueller]

Hi Jerome,

very nice work!

Jerome Quelin wrote:
> the existing find dialog would then be either kept as-is with ctrl+f, or
> moved to a replace action (ctrl+r or ctrl+h) since it doesn't do
> anything more than the incremental search.
> 
> ==> what do you think?

I'd move it to ctrl-f, too and move the current search window to 
search&replace with a different key binding.

I'll be a nit-picker:

The visuals still aren't perfect, though. Not that that's a deal breaker 
or anything. "Find:" is strangely flushed upwards in my laptop (kubuntu 
8.04). The "X" button would look better if it didn't have the extruded 
border. There is an option for this in wxButton, but it doesn't work 
*everywhere* according to the docs. The background should maybe have the 
same color as the darker gray background behind the search bar or 
"regex" could use some margin on the right.

This is all not a big deal. The only thing I'd consider a bug is that it 
can cover other things. See the following two screenshots. (First is 
normal with the above nits, second is "broken").

http://steffen-mueller.net/tmp/search.png
http://steffen-mueller.net/tmp/search2.png

Thanks for your great work!

Best regards,
Steffen