[Padre-dev] [Padre-commit] rev 962 - in trunk: . lib/Padre/Wx

[Jerome Quelin]

On 08/11/13 10:57 -0800, svn at perlide.org wrote:
> fix ticket #104: padre crashes when running ack
[...]
> --- trunk/lib/Padre/Wx/Ack.pm	2008-11-13 18:38:31 UTC (rev 961)
> +++ trunk/lib/Padre/Wx/Ack.pm	2008-11-13 18:57:55 UTC (rev 962)
> @@ -27,6 +27,17 @@
>  
>  sub on_ack {
>  	my ($self) = @_;
> +
> +	# check minimum App::Ack version
> +	my $minver = 1.86;
> +	if ( $App::Ack::VERSION < $minver ) {
> +		$self->error(
> +			"App::Ack $minver required for this function " .
> +			"(you have $App::Ack::VERSION installed)."
> +		);
> +		return;
> +	}
> +	
>  	@_ = (); # cargo cult or bug? see Wx::Thread / Creating new threads
>  
>  	# TODO kill the thread before closing the application

just one note about this fix: it is possible to have an app::ack version
installed below 1.86 - yes, even if Build.PL specifies a minimum
version.

since padre crashes if installed app::ack is too old, i preferred adding
this small check.

wdyt?
jérôme 
-- 
jquelin at gmail.com